Fix price used to determine volume if the last Execution was higher than the max price.

kraken-api_plain/KrakenTradeHistory.js

@@ -2,8 +2,14 @@
 2020-01-09 - get the gains generated by my automated ETC trading.
 2020-10-23 - fix problem because API requires windowing to handle more than 50 rows, implemented windowing.
 2020-12-02 - change to persist transactions and handle pairs as provided by commandline parameter.
+2020-12-04 - handle commandline inlcuding verbosity of output.
 */
 
+const yargs = require('yargs/yargs')
+const { hideBin } = require('yargs/helpers')
+const argv = yargs(hideBin(process.argv)).argv
+
+
 const key          = 'SOOOJ7OhVCOpJE4DAWz8v5B25UpdYya9buF8DFAkHzmUab5E9i0PlEPh'; // API Key
 const secret       = 'UytAbgU8ty3n5a+JhaoIlcfh8zM4OBGY6PCC+Cfg2NI4waVzM52BBp9qmmyczrTDQpeha8q3nHeE/p7wNWKiVA=='; // API Private Key
 const KrakenClient = require('kraken-api');
@@ -34,20 +40,25 @@ const utcToLocal = (utc) => {
 (async () => {
 	try {		
 		// get the pair to process from the first parameter and fall back if not provided.
-		let thePair=process.argv[2];
+		let thePair=argv.pair;
 		if (thePair===undefined) {
 			thePair="XXMRZUSD";
 		}
 		thePair=thePair.toUpperCase(); // the pairs are always upper case.	
 		console.log("Processing pair			: ", thePair);
 
-		let allTrades=loadData("allTrades.json");
+		let dataFile = argv.dataFile;
+		if (dataFile===undefined) {
+			dataFile = "allTrades.json";
+		}
+		let allTrades=loadData(dataFile);
 		let params={ ofs : 0 };
 		let maxTimestamp=0;
 		allTrades.forEach(dta=>{if (dta.time>maxTimestamp) {maxTimestamp=dta.time;} });
 		params.start=maxTimestamp;
 		console.log("Max-Timestamp			: ",maxTimestamp);			
 		
+		if (!argv.skipRequestTrades) {
 			let allTransactions = await kraken.api('TradesHistory', params);
 			let allTradeIDs=Object.keys(allTransactions.result.trades);
 			let numTrans=allTradeIDs.length;
@@ -59,7 +70,7 @@ const utcToLocal = (utc) => {
 				
 				// the timestamp is inclusive, therefore we have to skip that record.
 				if (theTrade.time === maxTimestamp) { continue; } 
-			console.log(theTrade);
+				if (argv.v) { console.log(theTrade); }
 			
 				allTrades.push(theTrade);
 				if ((params.ofs % 50) == 0) { 
@@ -73,8 +84,8 @@ const utcToLocal = (utc) => {
 
 			// sort the trades by time; oldest first.
 			allTrades=allTrades.sort(function (a,b){return(a.time - b.time);});
-		
+			storeData(allTrades,dataFile);
-		storeData(allTrades,"allTrades.json");
+		}
 		
 		let sumUSD=0;
 		let sumCommission=0;
@@ -85,7 +96,7 @@ const utcToLocal = (utc) => {
 				numTrades++;
 				
 				let tradeLocalTime=utcToLocal(new Date(theTrade.time * 1000)).toISOString().substr(0,19).replace('T',' ');
-				console.log(`${tradeLocalTime} [${theTrade.pair}] ${theTrade.type.substring(0,1)}#${Number(theTrade.vol).toFixed(4).padStart(10," ")}@${Number(theTrade.price).toFixed(2).padStart(8," ")} -> ${Number(theTrade.cost).toFixed(2).padStart(9," ")}(-${Number(theTrade.fee).toFixed(3).padStart(5," ")})`);
+				if (argv.v) {console.log(`${tradeLocalTime} [${theTrade.pair}] ${theTrade.type.substring(0,1)}#${Number(theTrade.vol).toFixed(4).padStart(10," ")}@${Number(theTrade.price).toFixed(2).padStart(8," ")} -> ${Number(theTrade.cost).toFixed(2).padStart(9," ")}(-${Number(theTrade.fee).toFixed(3).padStart(5," ")})`);}
 				
 				// selling adds $$$ to our Account, buying takes money out of the account
 				let multiplier=theTrade.type==="buy"?-1:1;